Skip to content

Commit

Permalink
Ninja: fix create-release WF
Browse files Browse the repository at this point in the history
* `NEXT_VERSION_NO_SNAPSHOT` wasn't set
* duplicate `cd python/`
  • Loading branch information
snazy committed Oct 18, 2022
1 parent 4b9ad5e commit 2935d4c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/actions/bump-versions/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ runs:
NEW_VERSION: ${{ inputs.new-version }}
run: |
# bump2version 1.0.1 has a bug: https://github.com/c4urself/bump2version/issues/214
if [[ "$(cd python/ ; python -c 'import pynessie; print(pynessie.__version__)')" != ${NEW_VERSION} ]] ; then
if [[ "$(python -c 'import pynessie; print(pynessie.__version__)')" != ${NEW_VERSION} ]] ; then
bump2version --no-commit --no-tag --allow-dirty --new-version ${NEW_VERSION} minor
# Call into pynessie to ensure bump2version didn't mess up anything
echo "pynessie at release-version $(python -c 'import pynessie; print(pynessie.__version__)')"
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release-create.yml
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ jobs:

- name: Get next patch version
run: |
echo "NEXT_VERSION=$(cat version.txt)" >> ${GITHUB_ENV}
NEXT_VERSION="$(cat version.txt)"
echo "NEXT_VERSION=${NEXT_VERSION}" >> ${GITHUB_ENV}
echo "NEXT_VERSION_NO_SNAPSHOT=${NEXT_VERSION%-SNAPSHOT}" >> ${GITHUB_ENV}
# Record the next development iteration in Git
Expand Down

0 comments on commit 2935d4c

Please sign in to comment.