Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when deserializing a mapping that already exists #80

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

UkoeHB
Copy link
Collaborator

@UkoeHB UkoeHB commented Oct 5, 2023

It is best not to panic for non-critical errors.

@UkoeHB UkoeHB requested a review from Shatur October 5, 2023 23:09
@Shatur Shatur enabled auto-merge (squash) October 5, 2023 23:13
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7fc85f2) 95.64% compared to head (838e575) 95.31%.
Report is 1 commits behind head on master.

❗ Current head 838e575 differs from pull request most recent head 6a0a6b4. Consider uploading reports for the commit 6a0a6b4 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   95.64%   95.31%   -0.33%     
==========================================
  Files          13       13              
  Lines         873      876       +3     
==========================================
  Hits          835      835              
- Misses         38       41       +3     
Files Coverage Δ
src/client.rs 87.07% <0.00%> (-1.82%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur Shatur merged commit d512ecf into projectharmonia:master Oct 5, 2023
4 checks passed
@UkoeHB UkoeHB deleted the fix_panic branch October 5, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants