Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove derive-more dependency #69

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Remove derive-more dependency #69

merged 1 commit into from
Oct 2, 2023

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Oct 2, 2023

I used it long time ago when I had reflection to reduce the boilerplate.
I think we should remove it now.

@Shatur Shatur requested a review from UkoeHB October 2, 2023 17:03
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (298d5c7) 94.17% compared to head (0e360ec) 95.66%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   94.17%   95.66%   +1.49%     
==========================================
  Files          11       11              
  Lines         807      808       +1     
==========================================
+ Hits          760      773      +13     
+ Misses         47       35      -12     
Files Coverage Δ
src/server.rs 97.34% <100.00%> (+<0.01%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@UkoeHB UkoeHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used that crate, fine with me

@Shatur Shatur merged commit 6692c48 into master Oct 2, 2023
6 checks passed
@Shatur Shatur deleted the remove-derive-more branch October 2, 2023 20:06
Shatur added a commit to RJ/bevy_replicon that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants