Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benches #41

Merged
merged 4 commits into from
Sep 20, 2023
Merged

Fix benches #41

merged 4 commits into from
Sep 20, 2023

Conversation

UkoeHB
Copy link
Collaborator

@UkoeHB UkoeHB commented Sep 20, 2023

Benches need a delay between server/client updates to allow messages to pass between them. Otherwise the tests fail.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cbc6825) 95.47% compared to head (55782fd) 95.47%.

❗ Current head 55782fd differs from pull request most recent head 6e69ce8. Consider uploading reports for the commit 6e69ce8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files          10       10           
  Lines         663      663           
=======================================
  Hits          633      633           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@UkoeHB
Copy link
Collaborator Author

UkoeHB commented Sep 20, 2023

I also added two new benchmarks for updating existing components.

@Shatur Shatur enabled auto-merge (squash) September 20, 2023 21:53
@Shatur Shatur disabled auto-merge September 20, 2023 22:03
@Shatur Shatur merged commit 6bcf4b0 into projectharmonia:master Sep 20, 2023
3 checks passed
@UkoeHB UkoeHB deleted the fix_benches branch September 20, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants