Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send removals for hidden entities #370

Merged
merged 6 commits into from
Dec 1, 2024
Merged

Do not send removals for hidden entities #370

merged 6 commits into from
Dec 1, 2024

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Dec 1, 2024

  • Added a simple check and a test that now passes (fails without the fix).
  • Added a similar test for despawns.
  • Use is_visible helper for despawns.

@Shatur Shatur enabled auto-merge (rebase) December 1, 2024 17:40
@Shatur Shatur requested a review from UkoeHB December 1, 2024 17:40
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (7e6c077) to head (04b619a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
+ Coverage   90.19%   90.20%   +0.01%     
==========================================
  Files          46       46              
  Lines        2559     2562       +3     
==========================================
+ Hits         2308     2311       +3     
  Misses        251      251              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@UkoeHB UkoeHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@Shatur Shatur disabled auto-merge December 1, 2024 22:26
@Shatur Shatur merged commit 42537ea into master Dec 1, 2024
5 checks passed
@Shatur Shatur deleted the checked-removal branch December 1, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants