Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put extra logic for ConfirmHistory::confirm under else #358

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Nov 19, 2024

The bit is set in set_last_tick, no need to call set after it.

The bit is set in `set_last_tick`, no need to call `set` after it.
@Shatur Shatur enabled auto-merge (rebase) November 19, 2024 22:21
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.98%. Comparing base (1e49d2d) to head (4fafba2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files          41       41           
  Lines        2367     2367           
=======================================
  Hits         2130     2130           
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Shatur Shatur requested a review from UkoeHB November 20, 2024 16:12
@Shatur Shatur merged commit bcb3a76 into master Nov 20, 2024
6 checks passed
@Shatur Shatur deleted the extra-confirm-logic branch November 20, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants