Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComponentId to all component-related contexts #343

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Nov 4, 2024

No description provided.

`ComponentId` is more like a key here, so it should come first.
@Shatur Shatur requested a review from UkoeHB November 4, 2024 19:45
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.06%. Comparing base (e27d05c) to head (b673344).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   90.05%   90.06%   +0.01%     
==========================================
  Files          37       37              
  Lines        2362     2365       +3     
==========================================
+ Hits         2127     2130       +3     
  Misses        235      235              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur Shatur merged commit c0911f4 into master Nov 4, 2024
6 checks passed
@Shatur Shatur deleted the ctx_component_id branch November 4, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants