Don't panic in scene::replicate for non-reflected components
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UkoeHB
reviewed
Sep 13, 2024
Comment on lines
+86
to
+92
| debug!("ignoring `{type_name}` because it's not registered"); | ||
| continue; | ||
| }; | ||
| let Some(reflect_component) = registration.data::<ReflectComponent>() else { | ||
| debug!("ignoring `{type_name}` because it's missing `#[reflect(Component)]`"); | ||
| continue; | ||
| }; |
There was a problem hiding this comment.
Is it right to use debug messages here? Often you don't have debug logs enables, which mean things silently fail. I'd go with warning if this is always a user error.
There was a problem hiding this comment.
It's just could be the indented by the user. For example, in my game I replicate calculated navigation paths from server, but I don't want to serialize them as part of the scene. So I just removed the reflection for them.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 89.77% 89.78%
=======================================
Files 37 37
Lines 2318 2320 +2
=======================================
+ Hits 2081 2083 +2
Misses 237 237 ☔ View full report in Codecov by Sentry. |
UkoeHB
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to remove some components that are replicated from scene serialization.