Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReplicatedClients::new public #325

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

UkoeHB
Copy link
Collaborator

@UkoeHB UkoeHB commented Sep 9, 2024

Ran into this while updating tests in bevy_girk. I access ReplicatedClients in the bevy_replicon_attributes plugin, and need the attributes plugin in some barebones tests that use attributes to manage replicated components.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (6814f55) to head (6a9df6e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          37       37           
  Lines        2317     2318    +1     
=======================================
+ Hits         2080     2081    +1     
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@UkoeHB UkoeHB requested a review from Shatur September 9, 2024 07:27
@Shatur Shatur merged commit e1fe579 into projectharmonia:master Sep 9, 2024
6 checks passed
@UkoeHB UkoeHB deleted the replicated_clients branch September 9, 2024 08:24
@Shatur
Copy link
Contributor

Shatur commented Sep 9, 2024

Do you want me to draft a patch release?

@UkoeHB
Copy link
Collaborator Author

UkoeHB commented Sep 9, 2024

@Shatur sure that would help. No rush though, patch.crates-io is working well atm.

@Shatur
Copy link
Contributor

Shatur commented Sep 9, 2024

@UkoeHB published :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants