Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client event buffering #323

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Fix client event buffering #323

merged 2 commits into from
Sep 3, 2024

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Sep 3, 2024

I rushed a little with removing generics.
We need to keep separate buffer for each event, otherwise events of
different types encoded in Bytes will be mixed together.

This commit is partial revert of e98a940.

I rushed a little with removing generics.
We need to keep separate buffer for each event, otherwise events of
different types encoded in Bytes will be mixed together.

This commit is partial revert of e98a940
@Shatur Shatur requested a review from UkoeHB September 3, 2024 21:11
@UkoeHB
Copy link
Collaborator

UkoeHB commented Sep 3, 2024

Add test for multiple event types?

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 87.30159% with 8 lines in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (52a92fa) to head (9d8be99).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/core/event_registry/server_event.rs 69.23% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   89.79%   89.77%   -0.03%     
==========================================
  Files          37       37              
  Lines        2293     2317      +24     
==========================================
+ Hits         2059     2080      +21     
- Misses        234      237       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur
Copy link
Contributor Author

Shatur commented Sep 3, 2024

@UkoeHB done!

@Shatur Shatur enabled auto-merge (squash) September 3, 2024 21:47
@Shatur Shatur merged commit 7729e74 into master Sep 3, 2024
6 checks passed
@Shatur Shatur deleted the fix-event-queue branch September 3, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants