Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ConnectedClients into ReplicatedClients #319

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Shatur
Copy link
Contributor

@Shatur Shatur commented Aug 9, 2024

Rename part of #316.
I think we should merge the rename first to make it easier to review. 316 will require more changes that I thought originally.

@Shatur Shatur force-pushed the rename-replicated-clients branch from a1315bd to afea1f6 Compare August 9, 2024 17:25
@Shatur Shatur requested a review from UkoeHB August 9, 2024 17:27
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (899783d) to head (afea1f6).
Report is 2 commits behind head on master.

Files Patch % Lines
src/server.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   91.05%   90.82%   -0.23%     
==========================================
  Files          36       36              
  Lines        2203     2235      +32     
==========================================
+ Hits         2006     2030      +24     
- Misses        197      205       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shatur Shatur merged commit c0cc6b7 into master Aug 9, 2024
6 checks passed
@Shatur Shatur deleted the rename-replicated-clients branch August 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants