Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Combining complex line shape and fake data generator" #67

Merged
merged 179 commits into from
Oct 31, 2024

Conversation

taliaweiss
Copy link
Collaborator

Branch used for Phase II Bayesian analysis.

Many of the comments on this unresolved PR likely apply, here: #53.

casesyh and others added 30 commits June 25, 2020 23:03
Copy link
Contributor

@cclaessens cclaessens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of this is in good shape. I suggest to add a little more description to the test_analysis scripts and the FakeDataGenerator and the MultiGasComplexLineshape processors. Make a note that they were used for Phase II analysis and describe how to use them.

The MultiGasLineshape processor is too long and has a lot of functions that we didn't use. At least everything related to the triangle response function can be deleted.
Add comments to the resolution function and other options in this processor that were used by the FakeDataGenerator for the official analysis.

@casesyh
Copy link
Contributor

casesyh commented Jul 11, 2024

The two line shape functions called are make_spectrum_simulated_resolution_scaled_fit_scatter_peak_ratio() and make_spectrum_gaussian_resolution_fit_scatter_peak_ratio(), which can be seen around this line https://github.com/project8/mermithid/blob/combining_ComplexLineShape_and_FakeDataGenerator/mermithid/misc/FakeTritiumDataFunctions.py#L317
Comments added to the complex line shape processor code to show that the two functions are called.

Yuhao's Mac and others added 7 commits July 11, 2024 09:36
…xed_survival_probability_partially_fixed_scatter_proportion(self, bins_Hz, eff_array, *p0) function
…he function spectrum_func_composite_gaussian_lorentzian_fixed_survival_probability_partially_fixed_scatter_proportion() around line number 2025
…. Addressed other comments by Christine in PR #67.
…tions and relevance to the Phase II analysis
@taliaweiss
Copy link
Collaborator Author

taliaweiss commented Jul 11, 2024

Building off of Yu-Hao's work, I expanded the file description at the top of the MultiGasComplexLineShape processor to explain how it is used in the Phase II analysis and correct some details.

I added similar descriptions to the tops of the test_analysis scripts and the FakeDataGenerator.

@taliaweiss taliaweiss merged commit 6fca22a into develop Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants