fix: quick metrics setup in kind with prometheus #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adodon2go
requested review from
rchincha,
andaaron and
eusebiu-constantin-petu-dbk
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1897 +/- ##
========================================
Coverage 91.92% 91.93%
========================================
Files 154 153 -1
Lines 26584 26434 -150
========================================
- Hits 24438 24301 -137
+ Misses 1586 1575 -11
+ Partials 560 558 -2 see 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rchincha
reviewed
Oct 6, 2023
rchincha
reviewed
Oct 6, 2023
|
Also can this be added as a nightly test? |
adodon2go
force-pushed
the
kind-metrics-script
branch
2 times, most recently
from
576e29c to
b62f1b8
Compare
andaaron
reviewed
Oct 11, 2023
Signed-off-by: Alexei Dodon <[email protected]>
adodon2go
force-pushed
the
kind-metrics-script
branch
from
b62f1b8 to
7dae950
Compare
I will add a new CI workflow to address this. |
Let's track this in #1930 |
andaaron
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
What does this PR do / Why do we need it:
We have a script in examples/metrics to quickly setup a kind cluster with prometheus support.
That can be used together with a running grafana instance to quickly display some graphs.
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.