Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): make dynamoDB aware of orignal/deduped blobs #1881

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

eusebiu-constantin-petu-dbk
Copy link
Collaborator

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1881 (990573f) into main (039648a) will decrease coverage by 0.08%.
The diff coverage is 81.15%.

@@            Coverage Diff             @@
##             main    #1881      +/-   ##
==========================================
- Coverage   92.00%   91.92%   -0.08%     
==========================================
  Files         153      153              
  Lines       26390    26434      +44     
==========================================
+ Hits        24279    24299      +20     
- Misses       1559     1577      +18     
- Partials      552      558       +6     
Files Coverage Δ
pkg/storage/cache/dynamodb.go 88.05% <81.15%> (-8.76%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eusebiu-constantin-petu-dbk eusebiu-constantin-petu-dbk force-pushed the fix_dynamo branch 3 times, most recently from a01041f to a036efa Compare October 5, 2023 09:26
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 53f97eb into project-zot:main Oct 10, 2023
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants