Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-33054 - Pipeline to sync protos #26

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

lennysgarage
Copy link
Collaborator

@lennysgarage lennysgarage commented Aug 28, 2024

@merlante suggestion about moving where the pipeline for syncing proto files simplifies things quite a bit.

Addressing comments from project-kessel/relations-api#143 (review):

  1. Using the peter-evans/create-pull-request action helps simplify a lot of the pull request business. "The default behaviour of the action is to create a pull request that will be continually updated with new changes until it is merged or closed" - https://github.com/peter-evans/create-pull-request?tab=readme-ov-file#action-behaviour
  2. Pipeline here runs a cronjob every 6 hours that pulls the relations-api copies any changes over and creates a PR, no PR is opened if no changes are made.
  3. Similar action could be added to go & python clients. Should be relatively simple to copy, just requires updating paths.
  4. Shouldn't be a problem since the protos will have been already committed to the main branch in the source of truth repo relations-api

Currently scheduled to run every 6 hours, but can also be manually triggered so if you want to copy right away you can.
Example PR: lennysgarage#6

Can also mostly resolve: #14

JIRA: https://issues.redhat.com/browse/RHCLOUD-33054

Copy link
Collaborator

@merlante merlante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lennysgarage lennysgarage merged commit e58a5ce into main Aug 29, 2024
1 check passed
@lennysgarage lennysgarage deleted the pipeline-sync-protos branch August 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants