Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize spicedb settings #261

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

lennysgarage
Copy link
Contributor

PR Template:

Describe your changes

  • Parameterizes spicedb params to defaults
    • Connections per pod max & min (20)
    • Quantization interval (5s)
    • Quantization staleness percentage (0.1)

Ticket reference (if applicable)

Fixes #

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
Copy link

The latest Buf updates on your PR. Results from workflow buf-pull-request / build (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedNov 12, 2024, 4:41 PM

@Rajagopalan-Ranganathan
Copy link
Contributor

Are all the values "strings" ? or some of them are integers?

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@lennysgarage
Copy link
Contributor Author

Are all the values "strings" ? or some of them are integers?

Referencing from perf they are all strings except Quantization interval which is just 5s but writing it as a string also succeeds

@Rajagopalan-Ranganathan
Copy link
Contributor

/lgtm

@lennysgarage lennysgarage merged commit d6818f6 into main Nov 13, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants