Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize SpiceDB memory&cpu requests and limits #244

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

lennysgarage
Copy link
Contributor

@lennysgarage lennysgarage commented Nov 1, 2024

PR Template:

Describe your changes

  • Parameterize SpiceDB memory and cpu requests/limits

Ticket reference (if applicable)

Fixes #

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

Copy link

github-actions bot commented Nov 1, 2024

The latest Buf updates on your PR. Results from workflow buf-pull-request / build (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedNov 1, 2024, 3:14 PM

@Rajagopalan-Ranganathan
Copy link
Contributor

/lgtm

@lennysgarage lennysgarage merged commit 59bfc90 into main Nov 1, 2024
9 of 11 checks passed
@lennysgarage lennysgarage deleted the parameterize-spicedb-requests-limits branch November 1, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants