Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-35760: updates dockerfile and deployment to allow for easier config #237

Conversation

tonytheleg
Copy link
Contributor

PR Template:

Describe your changes

  • updates the dockerfile to:
    • create a path for config vs using /usr/local/bin so that a config can be managed externally and not overwrite the directory
    • updates the entrypoint command for new config path
  • adds a default config to ephemeral deployment
  • updates the pod spec to mount the configmap as a file

Purpose:
The config is currently hard backed into the dockerfile which makes it difficult to provide different configs for every env, especially with some using auth, some not, and having different auth endpoints.

For ephemeral, the configmap is created with the deployment, allowing for local edits/testing

For stage/prod, the configmap will be deployed via App interface and is expected to exist to run. This will allow for configuring values that are env specific.

The config is still copied over to the image for the sake of local testing, but when using kubernetes, the configmap will be required after this change.

Ticket reference (if applicable)

Fixes #

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

@tonytheleg tonytheleg marked this pull request as ready for review October 24, 2024 12:44
@tonytheleg tonytheleg marked this pull request as draft October 24, 2024 13:23
@tonytheleg tonytheleg marked this pull request as ready for review October 24, 2024 15:28
Copy link
Contributor

@lennysgarage lennysgarage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on all the conversations around this with possible env vars issues and it still working in ephemeral this LGTM

@tonytheleg
Copy link
Contributor Author

/retest

@Rajagopalan-Ranganathan Rajagopalan-Ranganathan merged commit 96fd9c0 into project-kessel:main Oct 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants