Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize setup-python to resolve pip error #231

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

lennysgarage
Copy link
Contributor

PR Template:

Describe your changes

Ticket reference (if applicable)

Fixes #

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

Signed-off-by: Jonathan Marcantonio <[email protected]>
Copy link

github-actions bot commented Oct 16, 2024

The latest Buf updates on your PR. Results from workflow buf-pull-request / build (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedOct 16, 2024, 1:45 PM

Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
@lennysgarage
Copy link
Contributor Author

lint-yaml job can be seen working here from the previous commit: https://github.com/project-kessel/relations-api/actions/runs/11366972619/job/31618566168

@Rajagopalan-Ranganathan
Copy link
Contributor

/lgtm

@lennysgarage lennysgarage merged commit c64a4a5 into main Oct 16, 2024
9 of 10 checks passed
@lennysgarage lennysgarage deleted the resolve-lint-error branch October 16, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants