Disambiguate Health endpoint due to introduction of Kessel Inventory #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR check should pass after rebasing (had to update a package in main) |
This is technically a breaking change, but I don't think anything actually uses the health gRPC API. Also, regeneration highlighted that adding `optional`, while not breaking on the wire (probably?), it _does_ break code generation (see https://protobuf.dev/programming-guides/proto3/#updating), so I had to fix this too.
alechenninger
force-pushed
the
disambiguate-health-service
branch
from
ca01c21 to
7263356
Compare
|
Thanks! Rebased – merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change, but I don't think anything actually uses the health gRPC API.
Also, regeneration highlighted that adding
optional, while not breaking on the wire (probably?), it does break code generation (see https://protobuf.dev/programming-guides/proto3/#updating), so I had to fix this too. Namespace should be required, the fact that some types don't have this is the bug.PR Template:
Describe your changes
Ticket reference (if applicable)
Fixes #
Checklist
Are the agreed upon acceptance criteria fulfilled?
Was the 4-eye-principle applied? (async PR review, pairing, ensembling)
Do your changes have passing automated tests and sufficient observability?
Are the work steps you introduced repeatable by others, either through automation or documentation?
The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)
Are the agreed upon coding/architectural practices applied?
Are security needs fullfilled? (e.g. no internal URL)
Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)
For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?