Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common protobuf version to generate API files #107

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

lennysgarage
Copy link
Contributor

@lennysgarage lennysgarage commented Jun 20, 2024

PR Template:

Describe your changes

  • Built a dockerized protoc to pin the protobuf versioning for all.
  • Updated make config and make api to use dockerized protoc instead of user installation.
  • protoc version pinned @ v25.1

Ticket reference (if applicable)

Fixes # https://issues.redhat.com/browse/RHCLOUD-33323

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@lennysgarage lennysgarage marked this pull request as ready for review June 20, 2024 15:23
api/Dockerfile Outdated Show resolved Hide resolved
api/Dockerfile Outdated Show resolved Hide resolved
api/Dockerfile Outdated Show resolved Hide resolved
@merlante
Copy link
Contributor

merlante commented Jun 20, 2024

Just tested on your branch and it runs great. Image building takes a while, but the image is retained on the next run of make api, so it's very quick after that.

LGTM once the comments are all addressed.

Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
@Rajagopalan-Ranganathan
Copy link
Contributor

/lgtm

@Rajagopalan-Ranganathan Rajagopalan-Ranganathan merged commit 409a7c8 into main Jun 20, 2024
6 checks passed
@lennysgarage lennysgarage deleted the RHCLOUD-33323 branch June 20, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants