-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use common protobuf version to generate API files #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
Rajagopalan-Ranganathan
requested changes
Jun 20, 2024
merlante
reviewed
Jun 20, 2024
Just tested on your branch and it runs great. Image building takes a while, but the image is retained on the next run of LGTM once the comments are all addressed. |
Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
Signed-off-by: Jonathan Marcantonio <[email protected]>
lennysgarage
force-pushed
the
RHCLOUD-33323
branch
from
June 20, 2024 17:24
310fc7d
to
9f1964e
Compare
Signed-off-by: Jonathan Marcantonio <[email protected]>
Rajagopalan-Ranganathan
approved these changes
Jun 20, 2024
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Template:
Describe your changes
make config
andmake api
to use dockerized protoc instead of user installation.Ticket reference (if applicable)
Fixes # https://issues.redhat.com/browse/RHCLOUD-33323
Checklist
Are the agreed upon acceptance criteria fulfilled?
Was the 4-eye-principle applied? (async PR review, pairing, ensembling)
Do your changes have passing automated tests and sufficient observability?
Are the work steps you introduced repeatable by others, either through automation or documentation?
The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)
Are the agreed upon coding/architectural practices applied?
Are security needs fullfilled? (e.g. no internal URL)
Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)
For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?