Skip to content

Commit

Permalink
Address comments about new line, comment and example in deploy.sh and…
Browse files Browse the repository at this point in the history
… readme.md
  • Loading branch information
lpichler committed Apr 24, 2024
1 parent ad6f673 commit 2c18a82
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ This is demonstrating calling relationship api from rbac service in ephemeral en

Example:
```
./deploy.sh rbac /Users/liborpichler/Projects/insights-rbac
./deploy.sh rbac /Projects/insights-rbac
```

- Updates config bonfire file and add rbac component
Expand Down
3 changes: 1 addition & 2 deletions deploy/deploy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
RBAC_ARGUMENT="$1"
RBAC_DIR="$2"
if [ "$RBAC_ARGUMENT" == "rbac" ]; then

if [ ! -d "$RBAC_DIR" ]; then
echo "The directory $RBAC_DIR does not exist."
echo "Please specify local directory(absolute path) to copy of https://github.com/RedHatInsights/insights-rbac repository."
Expand Down Expand Up @@ -92,7 +91,7 @@ echo "postgress is ready"
# Create spiceDB bootstrap schema configmap
oc create configmap spicedb-schema --from-file=schema.yaml -n $NAMESPACE

#Deploy Relations service, spiceDB service
#Deploy Relations service, spiceDB service and rbac service when $RBAC_ARGUMENT is not empty
bonfire deploy $RBAC_ARGUMENT relationships -n $NAMESPACE --local-config-method merge

ROUTE=$(oc get routes --selector='app=relationships' -o jsonpath='{.items[*].spec.host}')
Expand Down

0 comments on commit 2c18a82

Please sign in to comment.