Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload test coverage artifact #269

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

sfowl
Copy link
Contributor

@sfowl sfowl commented Dec 13, 2024

Describe your changes

This is a second attempt at adding a test coverage report, follow up to #225

The problem with the previous report is that it relied on a bot comments on PRs, however permission for this is disabled on project-kessel repos. Instead, the comment is skipped and a markdown summary report is added to the build and test job. An example in my fork here.

I experiment with several different similar github actions, unfortunately the vast majority require write access to the repo in order to surface stats. This approach was the best low impact one I could come up with.

The html report is not used by the CI job and is just added for local testing convenience.

Important!

This change needs to merge in two stages:

  • first stage merges in the upload-artifact step, which uploads a coverage.out report
  • second stage uncomments and enables the coverage summary on PRs

The second stage will fail, if the first stage has not already been merged and run on main branch. I will create a second PR to uncomment and enable the coverage summary report after this PR merges.

Example:

image

Ticket reference (if applicable)

Fixes #RHCLOUD-35837

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

@sfowl sfowl requested a review from akoserwal December 13, 2024 01:55
@akoserwal akoserwal merged commit feb181f into project-kessel:main Dec 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants