Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-36114: Add configuration to optionally disable persistence #233

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

tylercreller
Copy link
Contributor

PR Template:

Describe your changes

  • Adds deploy config for disabling persistence

    • Will not make a DB connection during startup when disabled
    • Will not run migrations when disabled
    • Will not create/update/delete resources when disabled
    • Will not check DB during readyz/livez determination
  • Flattened biz logic for resource/relationships

    • Example
      if isTrue, err := checkIfTrue(); err != nil {
         return err
      } else {
        doSomething()
      }
      
      turns into
      isTrue, err := checkIfTrue()
      if err != nil {
        return err
      }
      doSomething()
      

Checklist

  • Are the agreed upon acceptance criteria fulfilled?

  • Was the 4-eye-principle applied? (async PR review, pairing, ensembling)

  • Do your changes have passing automated tests and sufficient observability?

  • Are the work steps you introduced repeatable by others, either through automation or documentation?

    • If automation is possible but not done due to other constraints, a ticket to the tech debt sprint is added
    • An SOP (Standard Operating Procedure) was created
  • The Changes were automatically built, tested, and - if needed, behind a feature flag - deployed to our production environment. (Please check this when the new deployment is done and you could verify it.)

  • Are the agreed upon coding/architectural practices applied?

  • Are security needs fullfilled? (e.g. no internal URL)

  • Is the corresponding Ticket in the right state? (should be on "review" now, put to done when this change made it to production)

  • For changes to the public API / code dependencies: Was the whole team (or a sufficient amount of ppl) able to review?

Copy link
Contributor

@tonytheleg tonytheleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you've tested this all out, this looks great to me!
LGTM

@tylercreller
Copy link
Contributor Author

tylercreller commented Nov 11, 2024

Assuming you've tested this all out, this looks great to me! LGTM

TY! For posterity, I've tested locally and in ephemeral envs with persistence on and off.

@tylercreller tylercreller merged commit 2feaac7 into project-kessel:main Nov 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants