Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds pdb, adds replicas param #209

Merged
merged 1 commit into from
Oct 28, 2024
Merged

adds pdb, adds replicas param #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion deploy/kessel-inventory-ephem.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ objects:
- kessel-relations
deployments:
- name: api
replicas: 1
replicas: ${{REPLICAS}}
podSpec:
initContainers:
- name: migration
Expand Down Expand Up @@ -96,3 +96,6 @@ parameters:
name: IMAGE_TAG
required: true
value: latest
- description: Number of replicas
name: REPLICAS
value: 1
14 changes: 13 additions & 1 deletion deploy/kessel-inventory.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ objects:
- kessel-relations
deployments:
- name: api
replicas: 1
replicas: ${{REPLICAS}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are double braces OK in here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, its actually required because replicas is not a string field so you can't use single. IIRC, double brace just inserts the value without quotes this way it shows up as a number

podSpec:
initContainers:
- name: migration
Expand Down Expand Up @@ -52,6 +52,15 @@ objects:
public:
enabled: true
apiPath: inventory
- kind: PodDisruptionBudget
apiVersion: policy/v1
metadata:
name: kessel-inventory-api-pdb
spec:
minAvailable: 1
selector:
matchLabels:
app: kessel-inventory
parameters:
- description: ClowdEnvironment name (ephemeral, stage, prod)
name: ENV_NAME
Expand All @@ -63,3 +72,6 @@ parameters:
name: IMAGE_TAG
required: true
value: latest
- description: Number of replicas
name: REPLICAS
value: 1
Loading