Merge pull request #211 from tonytheleg/RHCLOUD-35835-enhance-cmd-errors

RHCLOUD-35835: improves error messages for base commands

internal/authn/authn.go

@@ -1,6 +1,7 @@
 package authn
 
 import (
+	"fmt"
 	"github.com/go-kratos/kratos/v2/log"
 	"github.com/project-kessel/inventory-api/internal/authn/api"
 	"github.com/project-kessel/inventory-api/internal/authn/clientcert"
@@ -31,7 +32,7 @@ func New(config CompletedConfig, logger *log.Helper) (api.Authenticator, error)
 		if a, err := oidc.New(*config.Oidc); err == nil {
 			d.Add(a)
 		} else {
-			return nil, err
+			return nil, fmt.Errorf("failed to load OIDC info: %v", err)
 		}
 	}
 

internal/authn/oidc/oidc.go

@@ -25,7 +25,7 @@ func New(c CompletedConfig) (*OAuth2Authenticator, error) {
 	ctx := coreosoidc.ClientContext(context.Background(), c.Client)
 	provider, err := coreosoidc.NewProvider(ctx, c.AuthorizationServerURL)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("failed to create provider: %v", err)
 	}
 
 	if c.PrincipalUserDomain == "" {

internal/data/migrate.go

@@ -1,6 +1,8 @@
 package data
 
 import (
+	"fmt"
+
 	"github.com/project-kessel/inventory-api/internal/biz/model"
 	"gorm.io/gorm"
 
@@ -19,20 +21,20 @@ func Migrate(db *gorm.DB, logger *log.Helper) error {
 	}
 
 	if err := db.AutoMigrate(models...); err != nil {
-		return err
+		return fmt.Errorf("auto migration has failed: %v", err)
 	}
 
 	for _, m := range models {
 		if gormDbIndexStatement, ok := m.(model.GormDbAfterMigrationHook); ok {
 			statement := &gorm.Statement{DB: db}
 			err := statement.Parse(m)
 			if err != nil {
-				return err
+				return fmt.Errorf("statement parsing has failed: %v", err)
 			}
 
 			err = gormDbIndexStatement.GormDbAfterMigration(db, statement.Schema)
 			if err != nil {
-				return err
+				return fmt.Errorf("migration failure: %v", err)
 			}
 		}
 	}

internal/eventing/factory.go

@@ -17,7 +17,7 @@ func New(c CompletedConfig, source string, logger *log.Helper) (api.Manager, err
 	case "kafka":
 		km, err := kafka.New(c.Kafka, source, logger)
 		if err != nil {
-			return nil, err
+			return nil, fmt.Errorf("failed to create kafka manager: %w", err)
 		}
 		return km, nil
 	}

internal/server/server.go

@@ -2,6 +2,7 @@ package server
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/go-kratos/kratos/v2"
 	"github.com/go-kratos/kratos/v2/log"
@@ -33,22 +34,22 @@ func New(c CompletedConfig, authn middleware.Middleware, logger log.Logger) (*Se
 
 	meterProvider, err := NewMeterProvider(s)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("init meter provider failed: %v", err)
 	}
 
 	meter, err := NewMeter(meterProvider)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("init meter failed: %v", err)
 	}
 
 	httpServer, err := http.New(c.HttpConfig, authn, meter, logger)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("init http server failed: %v", err)
 	}
 
 	grpcServer, err := grpc.New(c.GrpcConfig, authn, meter, logger)
 	if err != nil {
-		return nil, err
+		return nil, fmt.Errorf("init grpc server failed: %v", err)
 	}
 
 	s.HttpServer = httpServer