improved code structure #3

dpshekhawat · 2022-08-01T18:17:31Z

Results of the PR:

More code readability.
Set environment variables for -

THRES -> for confidence threshold.
TIMEINT -> for time interval of capturing frames.
CAPTURE -> to stop capturing if set to False.

Not burning any CPU while waiting around.
Handling Permission Error.

main.py

pkliczewski

It looks much better but adding 3 more comments

main.py

pkliczewski · 2022-08-04T19:10:34Z

main.py

+    # Get Frames
+    ret, frame = cap.read()
+
+    if ret:


read method returns True if object is read correctly (reference). We only attempt to detect object if we fail.

main.py

pkliczewski · 2022-08-05T08:17:14Z

Looks great, the change is ready to merge

dpshekhawat added 2 commits July 22, 2022 15:12

improved code structure

78678df

set env variables

848a936

pkliczewski reviewed Aug 2, 2022

View reviewed changes

main.py Outdated Show resolved Hide resolved

main.py Show resolved Hide resolved

main.py Outdated Show resolved Hide resolved

main.py Outdated Show resolved Hide resolved

refactored code and performance improvements

3a18039

pkliczewski reviewed Aug 4, 2022

View reviewed changes

moved folder checking code outside loop

e58b6fc

dpshekhawat merged commit a1be881 into main Aug 5, 2022

dpshekhawat deleted the dev branch September 6, 2022 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improved code structure #3

improved code structure #3

dpshekhawat commented Aug 1, 2022 •

edited

Loading

pkliczewski left a comment

pkliczewski Aug 4, 2022

pkliczewski commented Aug 5, 2022

improved code structure #3

improved code structure #3

Conversation

dpshekhawat commented Aug 1, 2022 • edited Loading

pkliczewski left a comment

Choose a reason for hiding this comment

pkliczewski Aug 4, 2022

Choose a reason for hiding this comment

pkliczewski commented Aug 5, 2022

dpshekhawat commented Aug 1, 2022 •

edited

Loading