Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Alpine based image #2

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Alpine based image #2

merged 3 commits into from
Aug 15, 2022

Conversation

dpshekhawat
Copy link
Collaborator

@dpshekhawat dpshekhawat commented Jul 26, 2022

Description

This PR will change the base image to python-alpine to make the image lightweight.

Intended Outcome:
A lightweight image with Python3 and OpenCV for machine learning model.

Requirements

  • Python 3
  • OpenCV 4.6

Dockerfile Outdated
-D PYTHON3_PACKAGES_PATH=/usr/local/lib/python3.7/site-packages/ \
-D PYTHON3_NUMPY_INCLUDE_DIRS=/usr/local/lib/python3.7/site-packages/numpy/core/include/ \
.. && \
make VERBOSE=1 && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having VERBOSE=1 for development is great. Do we want to commit it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is temporary will remove it before merging it to main.

@pkliczewski
Copy link
Collaborator

image building with your dockerfile fails for me

@pkliczewski
Copy link
Collaborator

please make sure that it works. I checked and it failed for me. It would be good if you could compare it with the one I sent you

@dpshekhawat dpshekhawat marked this pull request as ready for review August 15, 2022 06:16
Copy link
Collaborator

@pkliczewski pkliczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@pkliczewski pkliczewski merged commit 64e6af4 into main Aug 15, 2022
@dpshekhawat dpshekhawat deleted the alpine-based-image branch September 6, 2022 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants