-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groups #37
Open
hel0t
wants to merge
16
commits into
project-fika:main
Choose a base branch
from
hel0t:3.9-groups
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Groups #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hel0t
force-pushed
the
3.9-groups
branch
3 times, most recently
from
July 3, 2024 08:54
8f3d68b
to
dbbd1a8
Compare
@Lacyway @TheSpartaPT I've removed chat related code and cherry picked squad updates on top of main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
FikaMatchController
to override default SPT match controller (SPT'sMatchController
lacked many methods that allow group functionality to work).FikaGroupService
for managing group related functions & state.groupId
/sessionId
for linking a player with their group & match etc.GameCallbacks
override which exposes thegetCurrentGroup
method for retrieving info on squad members.MatchCallbacks
override which exposesraidReady
&raidNotReady
methods for notifying other squad members of raid member ready status changes.FikaMatchStaticRouter
to expose the/client/match/raid/ready
&/client/match/raid/not-ready
endpoints.Updates:
FikaMatchController
with an extension to thestartOfflineRaid
method which sends the raid settings notification to group members..ProfileControllerOverride
with a new methodgetProfileStatus
to expose profile infoFikaRaidController
to link the player with their group in ahandleRaidGetHost
andhandleRaidJoin
.FikaMatchService
with group related info.FikaUpdateController
to add the groupId tohandleSpawnpoint
.FikaRaidStaticRouter
to add/fika/raid/group
to expose the group/raid info to assist theJoinMatch
method in the plugin.