Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Natpunch 3.9 dev #69

Merged
merged 16 commits into from
Jun 20, 2024
Merged

Natpunch 3.9 dev #69

merged 16 commits into from
Jun 20, 2024

Conversation

trippyone
Copy link
Collaborator

No description provided.

@Lacyway Lacyway self-requested a review June 17, 2024 07:24
@Lacyway Lacyway self-assigned this Jun 17, 2024
Lacyway
Lacyway requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@Lacyway Lacyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are mostly code formatting comments except for the port one.

Fika.Core/Coop/Components/FikaServerStunQuery.cs Outdated Show resolved Hide resolved
Fika.Core/Coop/Components/FikaServerStunQuery.cs Outdated Show resolved Hide resolved
Fika.Core/Fika.Core.csproj Show resolved Hide resolved
Fika.Core/Fika.Core.csproj Show resolved Hide resolved
Fika.Core/Fika.Core.csproj Show resolved Hide resolved
Fika.Core/Networking/NatPunch/FikaNatPunchClient.cs Show resolved Hide resolved
Fika.Core/Networking/NatPunch/FikaNatPunchClient.cs Show resolved Hide resolved
Fika.Core/Networking/NatPunch/FikaNatPunchServer.cs Show resolved Hide resolved
Fika.Core/Networking/NatPunch/NatPunchUtils.cs Show resolved Hide resolved
Fika.Core/Networking/NatPunch/NatPunchUtils.cs Outdated Show resolved Hide resolved
@trippyone
Copy link
Collaborator Author

trippyone commented Jun 20, 2024 •
edited
Loading

All review requests have been resolved. NatPunchRelayService is now using SPT's websocket so the port config is no longer needed.

@trippyone trippyone requested a review from Lacyway June 20, 2024 12:58
@Lacyway Lacyway merged commit 10e08c2 into 3.9-dev Jun 20, 2024
2 checks passed
@trippyone trippyone deleted the natpunch-3.9-dev branch June 23, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lacyway Lacyway Lacyway approved these changes

Assignees

@Lacyway Lacyway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trippyone @Lacyway