Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Offical version option and raid code #68

Merged
merged 18 commits into from
Jun 18, 2024
Merged

Add Offical version option and raid code #68

merged 18 commits into from
Jun 18, 2024

Conversation

yhl452493373
Copy link
Contributor

  • Add an option named "Official Version"
    • When it turn on, the displayed version label will change to the official version
    • When it turn off ( default option), the displayed version label is fika version
    • This configuration change will take effect immediately
  • When match created, a raid code will be generated. It will be shown as a part of version label
  • This will work with my pr: Add raid code Fika-Server#30

屏幕截图 2024-06-15 130953
![2024-06-15 13-09 _2 1, 1 5, -30 3_0 0, 0 6, 0 0, 0 8 (0)](https://github.com/project-fika/Fika-Plugin/assets/26134687/e40d7fdf-1f76-4a4f-b0b1-3b610a
2024-06-15 13-09 _2 2, 1 5, -30 3_0 1, 0 6, -0 1, 0 8 (0)
028be9)

@Lacyway
Copy link
Member

Lacyway commented Jun 15, 2024

I'll take a deeper look at this tomorrow, looks good so far.
Can I ask what the point/goal of this change is?

@yhl452493373
Copy link
Contributor Author

It just makes me feel more like online when playing. No other goals.

@Lacyway
Copy link
Member

Lacyway commented Jun 16, 2024

It just makes me feel more like online when playing. No other goals.

Ok!
I'll take a look at this tomorrow night hopefully, having a busy week, sorry. Will leave a review as soon as I can.

@Lacyway Lacyway self-assigned this Jun 17, 2024
Fika.Core/FikaPlugin.cs Outdated Show resolved Hide resolved
Fika.Core/Coop/Utils/FikaBackendUtils.cs Outdated Show resolved Hide resolved
Fika.Core/Coop/Utils/FikaBackendUtils.cs Outdated Show resolved Hide resolved
Fika.Core/UI/Patches/FikaVersionLabel_Patch.cs Outdated Show resolved Hide resolved
@Lacyway Lacyway merged commit c3cae3b into project-fika:3.9-dev Jun 18, 2024
1 check failed
@yhl452493373 yhl452493373 deleted the version-label-3.9-dev branch June 18, 2024 12:42
@yhl452493373 yhl452493373 restored the version-label-3.9-dev branch June 18, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants