Added the mod verification logic #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seionmoya
requested changes
May 29, 2024
Fika.Core/FikaPlugin.cs
Outdated
| @@ -46,7 +46,7 @@ namespace Fika.Core | |||
| /// Originally by: Paulov <br/> | |||
| /// Re-written by: Lacyway | |||
| /// </summary> | |||
| [BepInPlugin("com.fika.core", "Fika.Core", "0.9.8906")] | |||
| [BepInPlugin("com.project-fika.core", "Fika.Core", "0.9.8906")] | |||
There was a problem hiding this comment.
This should be in a separate PR as this is a breaking change for mods.
There was a problem hiding this comment.
I have reverted that commit from this PR.
This reverts commit e6f2b6b.
Lacyway
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I changed the BepInPlugin ID for FikaPlugin from "com.fika.core" to "com.project-fika.core". Any mods that required the ID to mark their plugin as required/incompatible will need to be updated to reflect this.
This notation is known as a "package" or "namespace". Typically the makeup is tld.domain.packagename. This is used to link back to the source. Typically developers who do not own a domain would use me.nexus4880.packagename though we own the domain project-fika.com, therefore we should be using that.
This wouldn't normally be something I'd even bring up though at the time of writing this fika.com is a registered domain and in my opinion we shouldn't attribute this package to them as they are not affiliated with this project.