Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hollowed references #61

Merged
merged 2 commits into from
May 30, 2024
Merged

Hollowed references #61

merged 2 commits into from
May 30, 2024

Conversation

seionmoya
Copy link
Contributor

@seionmoya seionmoya commented May 28, 2024

Switches from git submodules to hollowing all dlls.

Advantages

  • Simplified update process
  • CI/CD works on external forks
  • All users benefit (not only internal)

Considerations

  • Relies on an external tool (like BatchHollower) to hollow the referenced assemblies.

Notes

Update process changed; instead of using git submodules, you now hollow the dlls (to remove the method bodies of all types in the dlls), and drop them in the References/ folder.
This way no copyrighted code is shipped while still being signature compatible.
This is also what SPT is doing for Assembly-CSharp.dll (see hollowed.dll).

@seionmoya seionmoya added bug Something isn't working enhancement New feature or request labels May 28, 2024
@seionmoya seionmoya requested a review from Lacyway May 28, 2024 13:47
@seionmoya seionmoya self-assigned this May 28, 2024
@seionmoya seionmoya changed the base branch from main to 3.9-dev May 28, 2024 13:47
@Lacyway Lacyway merged commit 5fe4576 into 3.9-dev May 30, 2024
2 checks passed
@Lacyway Lacyway deleted the hollowed-references branch July 9, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants