Additional advanced options for ping & name plates #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a 3.9.0 build you can use to do this and retarget? 3.9.0 seems like it's not far off and it has big improvements so I decided to focus development on it instead. |
|
I don't have a 3.9.0 build, no, sorry. These are pretty surface level changes, I'm sure they can integrate straight in to 3.9.0, I just haven't set that up, nor do I have plans to until my group switches to 3.9.0 as stable. No big deal, I can re-implement later or whatever works. |
|
No worries, leave the PR and I'll migrate it to 3.9.0 next time I work on it. |
|
Will try to merge this today. |
Lacyway
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had wanted to add an option for Fontaine's FOV Fixes mod users to be able to still display name plates and pings when aiming with an optic scope, but to not apply the optic's zoom&FOV to the location of the name plate / ping sprite. To that end, I added a boolean toggle for each as an 'Advanced' option, not normally visible.
Also added parts of a feature request from ArcticFox037 on Discord as advanced options: minimum ping opacity and a toggle to not scale ping based on distance.
No breaking changes, defaults are set up so that anyone who does not look in the Advanced settings of Configuration Manager will not even notice a difference.