Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constructor exception in CoopObservedFirearmController #48

Merged

Conversation

ArchangelWTF
Copy link
Member

Relatively simple and straightforward fix, Unity doesn't want Time.time to be run immediately upon construction of a class throwing an exception and causing further exceptions down the line whenever checking ammo or any other actions occur.

@Lacyway Lacyway self-requested a review May 18, 2024 10:20
@Lacyway Lacyway self-assigned this May 18, 2024
Copy link
Member

@Lacyway Lacyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks.
I haven't noticed any exceptions here, how were they caused exactly?

@Lacyway Lacyway added the bug Something isn't working label May 18, 2024
@Lacyway Lacyway merged commit d598014 into project-fika:dev May 18, 2024
1 check failed
@ArchangelWTF
Copy link
Member Author

@Lacyway It seems to happen immediately upon spawning into a raid even on master (Which is why I initially targeted that) and can only be observed on the client, afterwards this seems to cause other exceptions that has to do anything hands controller related it didn't initialize properly.

image

@ArchangelWTF ArchangelWTF deleted the fix/ObservedFirearmController-exception branch May 18, 2024 10:29
@Lacyway
Copy link
Member

Lacyway commented May 18, 2024

@Lacyway It seems to happen immediately upon spawning into a raid even on master (Which is why I initially targeted that) and can only be observed on the client, afterwards this seems to cause other exceptions that has to do anything hands controller related it didn't initialize properly.

image

Is this happening every raid for you? I have never seen this exception before. Very interesting find. Could it be a mod?

@ArchangelWTF
Copy link
Member Author

Nothing mod related as just for a sanity check I moved those out, when I got the exception that I screenshotted I was only running the latest FIKA (master) and the latest AKI 3.8.3 libraries.

@Lacyway
Copy link
Member

Lacyway commented May 18, 2024

Damn, that's weird. The change does no harm anyway and prevents future errors. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants