-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix constructor exception in CoopObservedFirearmController #48
Fix constructor exception in CoopObservedFirearmController #48
Conversation
Dev > main | spt 3.8.1
Change wording to be "raid server" rather than just "server"
Dev > Main (DO NOT MERGE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks.
I haven't noticed any exceptions here, how were they caused exactly?
@Lacyway It seems to happen immediately upon spawning into a raid even on master (Which is why I initially targeted that) and can only be observed on the client, afterwards this seems to cause other exceptions that has to do anything hands controller related it didn't initialize properly. |
Is this happening every raid for you? I have never seen this exception before. Very interesting find. Could it be a mod? |
Nothing mod related as just for a sanity check I moved those out, when I got the exception that I screenshotted I was only running the latest FIKA (master) and the latest AKI 3.8.3 libraries. |
Damn, that's weird. The change does no harm anyway and prevents future errors. Thanks again! |
Relatively simple and straightforward fix, Unity doesn't want Time.time to be run immediately upon construction of a class throwing an exception and causing further exceptions down the line whenever checking ammo or any other actions occur.