[Silabs] General updates and fixes for the Silabs Wi-Fi platforms #36628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er save functions (#109)
|
Review changes with |
mkardous-silabs
added
the
changing-submodules-on-purpose
|
PR #36628: Size comparison from 9d60489 to 6277913 Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36628: Size comparison from 9d60489 to 1189113 Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36628: Size comparison from 9d60489 to 27b60f5 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36628: Size comparison from 9d60489 to a099608 Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
lpbeliveau-silabs
approved these changes
Nov 26, 2024
ksperling-apple
approved these changes
Nov 28, 2024
| @@ -319,6 +319,7 @@ sl_status_t sl_wfx_host_reset_chip(void) | |||
| *****************************************************************************/ | |||
| sl_status_t sl_wfx_host_wait_for_wake_up(void) | |||
| { | |||
| xSemaphoreTake(wfx_wakeup_sem, pdMS_TO_TICKS(0)); | |||
There was a problem hiding this comment.
why was this added ?
There was a problem hiding this comment.
I had initially removed this because it seemed like an odd thing to do. After double checking the Si SDK file from which this was created from, that is what the platform do so i added the line back to match.
rosahay-silabs
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR upstreams a few updates and fixes for the different silabs Wi-Fi platforms
Tests