Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Implement DiagnosticLog #36591

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[Android] Implement DiagnosticLog #36591

wants to merge 1 commit into from
+955 −2

Conversation

joonhaengHeo
Copy link
Contributor

Fix #31647

Implement DiagnosticLog in Android ChipTool and Java controller.

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Nov 21, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  examples/android/CHIPTool/app/src/main/AndroidManifest.xml Unsupported file format
  examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/SelectActionFragment.kt Unsupported file format
  examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/clusterclient/DiagnosticLogFragment.kt Unsupported file format
  examples/android/CHIPTool/app/src/main/res/layout/diagnostic_log_fragment.xml Unsupported file format
  examples/android/CHIPTool/app/src/main/res/layout/select_action_fragment.xml Unsupported file format
  examples/android/CHIPTool/app/src/main/res/values/strings.xml Unsupported file format
  examples/android/CHIPTool/app/src/main/res/xml/file_paths.xml Unsupported file format
  examples/java-matter-controller/BUILD.gn Unsupported file format
  examples/java-matter-controller/java/src/com/matter/controller/Main.kt Unsupported file format
  examples/java-matter-controller/java/src/com/matter/controller/commands/bdx/DownloadLogCommand.kt Unsupported file format
  src/controller/java/AndroidLogDownloadFromNode.cpp Unsupported file format
  src/controller/java/AndroidLogDownloadFromNode.h Unsupported file format
  src/controller/java/BUILD.gn Unsupported file format
  src/controller/java/BdxDiagnosticLogsReceiver.cpp Unsupported file format
  src/controller/java/BdxDiagnosticLogsReceiver.h Unsupported file format
  src/controller/java/CHIPDeviceController-JNI.cpp Unsupported file format
  src/controller/java/src/chip/devicecontroller/ChipDeviceController.java  0% smaller
  src/controller/java/src/chip/devicecontroller/DiagnosticLogType.java  0% smaller
  src/controller/java/src/chip/devicecontroller/DownloadLogCallback.java  0% smaller
  src/protocols/bdx/BdxTransferDiagnosticLog.cpp Unsupported file format
  src/protocols/bdx/BdxTransferServerDelegate.h Unsupported file format
  src/protocols/bdx/BdxUri.h Unsupported file format

bzbarsky-apple
bzbarsky-apple reviewed Nov 22, 2024
View reviewed changes
src/protocols/bdx/BdxTransferServerDelegate.h
return CHIP_ERROR_NOT_IMPLEMENTED;
}

virtual CHIP_ERROR OnTransferData(BDXTransferProxy * transfer, const ByteSpan & data, bool isEof)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? The transfer ends OnTransferEnd, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple left review comments

Assignees
No one assigned
Labels
controller examples protocols
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] Add diagnostic log capability in java controller and android chip-tool
2 participants
@joonhaengHeo @bzbarsky-apple