[Silabs] Adds refrigerator app matter shell support for change door state #36548
+233
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
|
@shgutte You'll have to reformat your code. 1 test is failing. |
|
Building this PR for BRD2703A fails ./scripts/examples/gn_silabs_example.sh ./examples/refrigerator-app/silabs/ ./out/refrigerator-app-shell BRD2703A chip_build_libshell=trueBuild error In file included from ../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/src/lib/support/CodeUtils.h:34,
from ../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/src/lib/core/Optional.h:32,
from ../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/src/app/ConcreteAttributePath.h:23,
from ../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/zzz_generated/app-common/app-common/zap-generated/cluster-objects.h:26,
from ../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/src/app/clusters/refrigerator-alarm-server/refrigerator-alarm-server.h:20,
from ../../../examples/refrigerator-app/silabs/include/EventHandlerLibShell.h:19,
from ../../../examples/refrigerator-app/silabs/src/EventHandlerLibShell.cpp:18:
../../../examples/refrigerator-app/silabs/src/EventHandlerLibShell.cpp: In function 'CHIP_ERROR RefrigeratorDoorEventHandler(int, char**)':
../../../examples/refrigerator-app/silabs/src/EventHandlerLibShell.cpp:109:26: error: format '%d' expects argument of type 'int', but argument 4 has type 'chip::app::Cluster s::RefrigeratorAlarm::AlarmBitmap' [-Werror=format=]
109 | ChipLogProgress(Zcl, "Setting event for the door state %d", data->doorState);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~
| |
| chip::app::Clusters::RefrigeratorAlarm::AlarmBitmap
../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/src/lib/support/logging/TextOnlyLogging.h:469:70: note: in definition of macro 'ChipInternalLogImpl'
469 | chip::Logging::Log(chip::Logging::kLogModule_##MOD, CAT, MSG, ##__VA_ARGS__); \
| ^~~
../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/src/lib/support/logging/TextOnlyLogging.h:110:40: note: in expansion of macro 'ChipInternalLog'
110 | #define ChipLogProgress(MOD, MSG, ...) ChipInternalLog(MOD, PROGRESS, MSG, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
../../../examples/refrigerator-app/silabs/src/EventHandlerLibShell.cpp:109:5: note: in expansion of macro 'ChipLogProgress'
109 | ChipLogProgress(Zcl, "Setting event for the door state %d", data->doorState);
| ^~~~~~~~~~~~~~~
../../../examples/refrigerator-app/silabs/src/EventHandlerLibShell.cpp:109:61: note: format string is defined here
109 | ChipLogProgress(Zcl, "Setting event for the door state %d", data->doorState);
| ~^
| |
| int
../../../examples/refrigerator-app/silabs/src/EventHandlerLibShell.cpp: In function 'void EventWorkerFunction(intptr_t)':
../../../examples/refrigerator-app/silabs/src/EventHandlerLibShell.cpp:158:30: error: format '%d' expects argument of type 'int', but argument 4 has type 'chip::app::Cluster s::RefrigeratorAlarm::AlarmBitmap' [-Werror=format=]
158 | ChipLogProgress(Zcl, "Changing the door state %d", alarmData->doorState);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~
| |
| chip::app::Clusters::RefrigeratorAlarm::AlarmBitmap
../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/src/lib/support/logging/TextOnlyLogging.h:469:70: note: in definition of macro 'ChipInternalLogImpl'
469 | chip::Logging::Log(chip::Logging::kLogModule_##MOD, CAT, MSG, ##__VA_ARGS__); \
| ^~~
../../../examples/refrigerator-app/silabs/third_party/connectedhomeip/src/lib/support/logging/TextOnlyLogging.h:110:40: note: in expansion of macro 'ChipInternalLog'
110 | #define ChipLogProgress(MOD, MSG, ...) ChipInternalLog(MOD, PROGRESS, MSG, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
../../../examples/refrigerator-app/silabs/src/EventHandlerLibShell.cpp:158:9: note: in expansion of macro 'ChipLogProgress'
158 | ChipLogProgress(Zcl, "Changing the door state %d", alarmData->doorState);
| ^~~~~~~~~~~~~~~
../../../examples/refrigerator-app/silabs/src/EventHandlerLibShell.cpp:158:56: note: format string is defined here
158 | ChipLogProgress(Zcl, "Changing the door state %d", alarmData->doorState);
| ~^
| |
| int
At global scope:
cc1plus: note: unrecognized command-line option '-Wno-unknown-warning-option' may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors
[841/895] c++ obj/third_party/connectedhomeip/examples/platform/silabs/efr32-common.OTAConfig.cpp.o |
|
Thanks. Building this PR for BRD2703A is OK now: |
jmartinez-silabs
requested changes
Nov 20, 2024
Adds changes to fix this build error |
jmartinez-silabs
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Unable to test the test case TC-REFALM-2.2 due to the lack of functionality to open and close the refrigerator door.
Solution: Added support in the Matter shell to modify the door state.
Tested On: SiWx917 device with test case TEFALM-2.2.