Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch instead of delete from options hash #453

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Fetch instead of delete from options hash #453

merged 5 commits into from
Sep 9, 2024

Conversation

ryanmccarthypdx
Copy link
Contributor

@ryanmccarthypdx ryanmccarthypdx commented Aug 8, 2024 •
edited
Loading

This PR seeks to address Issue 451

Checklist:

  • I have updated the necessary documentation
  • I have signed off all my commits as required by DCO
  • My build is green

@ryanmccarthypdx ryanmccarthypdx mentioned this pull request Aug 9, 2024
Closed
2 tasks
lessthanjacob
lessthanjacob reviewed Aug 12, 2024
View reviewed changes
lib/blueprinter/base.rb Outdated Show resolved Hide resolved
lib/blueprinter/helpers/base_helpers.rb Outdated Show resolved Hide resolved
@ryanmccarthypdx ryanmccarthypdx marked this pull request as ready for review August 26, 2024 20:21
@ryanmccarthypdx ryanmccarthypdx requested review from ritikesh and a team as code owners August 26, 2024 20:21
jhollinger
jhollinger approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@jhollinger jhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lessthanjacob
lessthanjacob approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@lessthanjacob lessthanjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lessthanjacob lessthanjacob merged commit 3345d57 into procore-oss:main Sep 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lessthanjacob lessthanjacob lessthanjacob approved these changes

@jhollinger jhollinger jhollinger approved these changes

@ritikesh ritikesh Awaiting requested review from ritikesh ritikesh is a code owner

Assignees

@ryanmccarthypdx ryanmccarthypdx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanmccarthypdx @jhollinger @lessthanjacob