Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DONTMERGE helpers.Args0() get's it wrong if appimaged is in PATH #107

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eMPee584
Copy link
Contributor

This a glitch I found when I hot-replaced the daemon binary in my VM experiments..
helpers.Args0 prepends invocation path (cwd) instead of executable location
f.e. instead of /usr/local/bin/appimaged writes /home/user/appimaged into
service file

.. this is what I found to work.. sorry, just a demo patch xD

prepends invocation path (cwd) instead of executable location
f.e. instead of /usr/local/bin/appimaged writes /home/user/appimaged into
service file
@probonopd
Copy link
Owner

probonopd commented Nov 27, 2020

Are you using our official appimaged AppImage?
appimaged is only supported when being used from inside the official appimaged AppImage. Everything else is not in our control...

@eMPee584
Copy link
Contributor Author

Just checked it, yes the official appimaged-587-x86_64.AppImage computes ai.path to $CWD/$0

@probonopd
Copy link
Owner

Can you give an example of how to reproduce it a) when it goes wrong b) when it goes right? Thank you, this will help a lot.

@eMPee584
Copy link
Contributor Author

eMPee584 commented Nov 28, 2020

Sure. Put latest image at /usr/local/bin/appimaged (or anywhere else in $PATH) cd to f.e. /tmp, invoke appimaged and check ai.path ..

@probonopd probonopd marked this pull request as draft April 17, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants