Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go-appimaged continuus error codes logged #240

Open
Englishman100 opened this issue Jan 8, 2023 · 3 comments
Open

go-appimaged continuus error codes logged #240

Englishman100 opened this issue Jan 8, 2023 · 3 comments

Comments

@Englishman100
Copy link

The progam itself seems to work fine, creating and deleting menu entries for appimages, but a continuous stream of the following message is being created, e.g.

2023/01/08 12:18:58 org.kde.Solid.PowerManagement might not be started yet. Waiting a moment then retrying

The message is repeated about twice a second.

The go-appimaged program works on Arch Linux, Debian Bookworm, Fedora 37 and OpenSUSE Tumbleweed. But the error message occurs on all of the distros too.

@CalebQ42
Copy link
Contributor

CalebQ42 commented Jan 8, 2023

This occurs when both org.gtk.vfs.Udisks2VolumeMonitor and org.kde.Solid.PowerManagement (usually provided by powerdevil) are not available. In fixing #48, I forgot to add a break out for the loop waiting for org.kde.Solid.PowerManagement to start up (since it can take a moment). This ultimately doesn't break anything as it's done in a goroutine and the feature would be gracefully disabled anyway. It's of course never great to spam the log and this issue is fixed in #235.

@nerdling
Copy link

nerdling commented Jan 17, 2023

Since that PR has been open for over a month, any chance the fix for this issue can get merged independently?

@CalebQ42
Copy link
Contributor

You could always build my fork, or you can add the single line I forgot and it should work properly.

diff --git a/src/appimaged/udisks.go b/src/appimaged/udisks.go
index 7295ce1..efdb140 100644
--- a/src/appimaged/udisks.go
+++ b/src/appimaged/udisks.go
@@ -127,6 +127,7 @@ retry:
                } else {
                        log.Println("org.kde.Solid.PowerManagement might not be started yet. Waiting a moment then retrying")
                        time.Sleep(500 * time.Millisecond)
+                       retried = true
                        goto retry
                }
        } else {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants