Prevent loop of unsuccessfull attempts (invalid cross-device link) to…

… move desktop file when user's cache directory lies on a tmpfs mount (unburden-home-dir set up to minimize flash writes)

appimaged: 2020/11/29 19:33:24 Registering AppImages in [/home/user/Downloads /home/user/Desktop /home/user/Applications /opt /usr/local/bin]
appimaged: 2020/11/29 ERROR main: rename /home/user/.cache/applications//appimagekit_6f9acfe2118f26ccc7b52fb34e248f97.desktop /home/user/.local/share/applications/appimagekit_6f9acfe2118f26ccc7b52fb34e248f97.desktop: invalid cross-device link
appimaged: 2020/11/29 19:33:27 main: Moved 1 desktop files to /home/user/.local/share/applications/; use -v to see details
appimaged: 2020/11/29 19:33:27 Desktop notification:  Added application
appimaged: 2020/11/29 19:33:27 Ran update-desktop-database /home/user/.local/share/applications/

src/appimaged/appimaged.go

@@ -19,6 +19,7 @@ import (
 
 	"github.com/probonopd/go-appimage/internal/helpers"
 	"github.com/prometheus/procfs"
+	crossdevice "gist.github.com/eMPee584/640770aacd7d744124bccbf311a6a790.git"
 )
 
 // TODO: Understand whether we can make clever use of
@@ -314,7 +315,7 @@ func moveDesktopFiles() {
 		if *verbosePtr == true {
 			log.Println("main: Moving", file.Name(), "to", xdg.DataHome+"/applications/")
 		}
-		err = os.Rename(desktopcachedir+"/"+file.Name(), xdg.DataHome+"/applications/"+file.Name())
+		err = crossdevice.MoveFile(desktopcachedir+"/"+file.Name(), xdg.DataHome+"/applications/"+file.Name())
 		helpers.LogError("main", err)
 	}