Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split CI workflows #349

Merged
merged 21 commits into from
Sep 23, 2024
Merged

Split CI workflows #349

merged 21 commits into from
Sep 23, 2024

Conversation

thomass-dev
Copy link
Collaborator

@thomass-dev thomass-dev commented Sep 18, 2024 •
edited
Loading

  • split CI workflow into three pieces lint/frontend/backend to run workflows only when needed
  • run tests only on pull_request events
  • add dedicated build step in frontend workflow
  • update pre-commit hooks version to be up-to-date

@thomass-dev thomass-dev linked an issue Sep 18, 2024 that may be closed by this pull request
Run python pre-commit hooks only when files in src/ are changed #83
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

Coverage Report for ./frontend

Status Category Percentage Covered / Total
🔵 Lines 86.74% 1067 / 1230
🔵 Statements 86.74% 1067 / 1230
🔵 Functions 59.64% 34 / 57
🔵 Branches 82.3% 107 / 130
File CoverageNo changed files found.
Generated in workflow #6

thomass-dev
thomass-dev commented Sep 18, 2024
View reviewed changes
frontend/package.json Outdated Show resolved Hide resolved
thomass-dev
thomass-dev commented Sep 18, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@augustebaum augustebaum marked this pull request as ready for review September 18, 2024 10:11
@thomass-dev thomass-dev changed the title Split CI workflow into two pieces frontend/backend Split CI workflows Sep 18, 2024
rouk1
rouk1 requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@rouk1 rouk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a nice effort to have a more modular CI. But please do not remove tools from the frontend dev workflow.

.github/workflows/lint.yml Outdated Show resolved Hide resolved
.github/workflows/test-backend.yml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
frontend/package.json Outdated Show resolved Hide resolved
frontend/package.json Outdated Show resolved Hide resolved
@thomass-dev thomass-dev marked this pull request as draft September 18, 2024 14:49
@augustebaum augustebaum mentioned this pull request Sep 19, 2024
Open
@thomass-dev thomass-dev force-pushed the 83-run-python-pre-commit-hooks-only-when-files-in-src-are-changed branch from b5cd39a to 750d4da Compare September 20, 2024 12:21
@thomass-dev thomass-dev force-pushed the 83-run-python-pre-commit-hooks-only-when-files-in-src-are-changed branch 2 times, most recently from 9e8dd69 to e61b67b Compare September 20, 2024 13:59
@thomass-dev thomass-dev force-pushed the 83-run-python-pre-commit-hooks-only-when-files-in-src-are-changed branch from e61b67b to 8639225 Compare September 20, 2024 15:06
@thomass-dev thomass-dev marked this pull request as ready for review September 23, 2024 07:29
@thomass-dev thomass-dev marked this pull request as draft September 23, 2024 08:00
@thomass-dev thomass-dev force-pushed the 83-run-python-pre-commit-hooks-only-when-files-in-src-are-changed branch from 1adc76c to 575ae0d Compare September 23, 2024 08:09
@thomass-dev thomass-dev marked this pull request as ready for review September 23, 2024 08:11
@rouk1 rouk1 merged commit 879e5ce into main Sep 23, 2024
6 checks passed
@rouk1 rouk1 deleted the 83-run-python-pre-commit-hooks-only-when-files-in-src-are-changed branch September 23, 2024 08:15
@augustebaum augustebaum mentioned this pull request Sep 24, 2024
Closed
@thomass-dev thomass-dev linked an issue Sep 24, 2024 that may be closed by this pull request
Install dist in CI instead of source #344
Closed
@thomass-dev thomass-dev mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustebaum augustebaum augustebaum left review comments

@rouk1 rouk1 rouk1 approved these changes

Assignees

@thomass-dev thomass-dev

@augustebaum augustebaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install dist in CI instead of source Run python pre-commit hooks only when files in src/ are changed
3 participants
@thomass-dev @rouk1 @augustebaum