fix: source maps to work correctly #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return null; | ||
| }, |
There was a problem hiding this comment.
The tests seem to pass when removing this entire retrieveSourceMap function. Is it necessary?
There was a problem hiding this comment.
Nice catch :)
Indeed, tests are OK without it.
It might have been useful at some point in the development process but its no longer the case so it should be removed.
We can also remove direct dependency to source-map-url.
|
Great PR! Thanks for contributing. |
| @@ -41,9 +41,9 @@ | |||
| "webpack": "4 || 5" | |||
| }, | |||
| "dependencies": { | |||
| "@cspotcode/source-map-support": "^0.8.1", | |||
There was a problem hiding this comment.
It's not clear to me how this fork is different from the original source-map-support so I'm going to revert this.
NVM just saw the issue you linked!
privatenumber
changed the title
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I was experimenting with this nice tool of yours but I could not manage to get a usable stack trace by following the instructions of the
README.mdat How do I enable source-maps?.Here's my attempt at fixing this issue :)
This PR replaces
source-map-supportwith the more up to date@cspotcode/source-map-supportfork.See this issue on Github for the differences between the two.
It also adds a dependency to
source-map-urlwhich I use to parse the compiled sources to get the URL of the source map file.This PR also includes tests for different source map types.