Set max gap to 32 for low delay connections #1764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing performance, we observed that the data rate of long duration connections was lower than short connections. For example, instead of seeing data rates of 3 Gbps with Cubic, we were seeing data rates of 1.5 Mbps.
Analyzing the data showed that picoquic was setting the "max ACK GAP" to very large values, and that ACKs were only sent when the max ACK delay expired, i.e., after 1ms. Capping the "max ack gap" to never exceed 32 packets has a radical effect on the observed Cubic performance. Instead of 1.5 Gbps +- 8%, I now see 3.36 Gbps +- 1%!
We don't see the same improvement for BBR. We see some: the dark blue line (BBR with 32 cap on ack gap) is a bit above the light blue one. Some bad effects are gone: there are no spurious packet losses any more. But there is still work to do to improve that behavior.