Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf protocol enhancements for media streams #1762

Merged
merged 22 commits into from
Nov 14, 2024
Merged

Conversation

huitema
Copy link
Collaborator

@huitema huitema commented Oct 14, 2024

We are enhancing the "QUIC Perf" protocol to enable performance testing of multimedia transports. The goal is to test the processing of a realistic multimedia load by the transport stack.

First step is to write down the specification, as part of doc/quicperf.md

Copy link
Collaborator

@suhasHere suhasHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I wonder if we can add an example showing how to use the sample scenario with the grammar

@huitema
Copy link
Collaborator Author

huitema commented Oct 16, 2024

I am implementing the syntax parser, and I think I need to make some changes.

The old syntax carried two stream-id: the ID of the stream on which the data is send, and the id of the stream after which the data is sent. This allowed description of scenarios such as "send this on stream 4, and when it is all done send that on stream 8". It was convenient for initial tests, but it forced scenarios developers to understand stream numbering, deal with obscure error, and get a narrow view of scenarios.

I naturally added an identifier to the streams, mostly because that's needed for tying scenarios and reports. But if we have alphanumeric stream ids, the concept above can be expressed as "start stream AAA, and then start stream BBB after AAA completes." That's probably easier to understand. The actual stream numbers can be assigned by the stack. In fact they will need to, because if we do "quic stream by subgroup" there will be multiple quic stream for a media stream.

@huitema huitema merged commit 9c4ae62 into master Nov 14, 2024
11 checks passed
@huitema huitema deleted the perf-media-update branch November 14, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants