Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten reset loop prevention #1665

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Tighten reset loop prevention #1665

merged 1 commit into from
Mar 28, 2024

Conversation

huitema
Copy link
Collaborator

@huitema huitema commented Mar 28, 2024

Looking at a report from a nasty loop between Google QUIC servers and an UDP ECHO service incited two changes in the code:

  1. Add the ECHO service (UDP port 7) to the list of ports that are protected against reflection attacks.
  2. Update the code of the stateless reset generation to make it obvious that the stateless reset will always be at least one byte shorter that the incoming packet.

The other precautions in the code are unchanged, in particular the rate limiting of packet resets, by default enforcing a delay of at least 100ms between consecutive stateless reset packets.

@huitema huitema merged commit 900c3a8 into master Mar 28, 2024
11 checks passed
@huitema huitema deleted the prevent-reset-loop branch March 28, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant