ACK and Stream are not path probing #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemethf
reviewed
Dec 2, 2023
picoquic/frames.c
Outdated
| @@ -5263,15 +5263,15 @@ int picoquic_decode_frames(picoquic_cnx_t* cnx, picoquic_path_t * path_x, const | |||
| { | |||
| const uint8_t *bytes_max = bytes + bytes_maxsize; | |||
| int ack_needed = 0; | |||
| int is_path_validating_packet = 1; /* Will be set to zero if non validating frame received */ | |||
| int is_path_probing_packet = 1; /* Will be set to zero if non validating frame received */ | |||
There was a problem hiding this comment.
Maybe the comment should be updated as well.
(Thank you for your quick response.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1587