Allow debug output to be delivered via callbacks #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitema
requested changes
Sep 1, 2023
There was a problem hiding this comment.
Looks good, but please fix the warning in appveyor:
"C:\projects\picoquic\picoquic.sln" (default target) (1) ->
"C:\projects\picoquic\picoquic\picoquic.vcxproj" (default target) (2) ->
(ClCompile target) ->
c:\projects\picoquic\picoquic\util.c(168): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\projects\picoquic\picoquic\picoquic.vcxproj]
c:\projects\picoquic\picoquic\util.c(172): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data
paulej
force-pushed
the
paulej_logging_callback
branch
from
0166743
to
67d7f12
Compare
|
@huitema Thanks for pointing that out. I fixed that issue, as requested. |
paulej
force-pushed
the
paulej_logging_callback
branch
from
67d7f12
to
64bf8ed
Compare
|
Actually, I don't like where I defined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow both normal debug logging and
debug_dump()output to be delivered to the application via callback functions. This is useful so that debug output can be seamlessly integrated with other logging output. The changes allow the user to specify either a logging stream or callback function, but not both. (I did not see a use case for allowing delivery of messages to two places, but I have no objection to it.)