This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
refactor(lib): client config #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brech1
force-pushed
the
refactor/client-config
branch
from
1364598 to
408125b
Compare
lazovicff
approved these changes
Oct 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
ClientConfigstruct from the main library. The main purpose of it was to simplify settings storage, but this is an application and not a library concern. It also had data that the library itself wasn't using.It has been moved to the CLI crate and the
Clientconstructor has been updated to receive the necessary data to spin up, and store in memory whatever is needed for the library methods.Related Issues
Changes
ClientConfigfrom the library and implementCliConfigin the CLI.